Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: do not check all fields of UndefVarError for egal #10

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 2, 2023

Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to remove the two @test macros in front of the try blocks.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #10 (a886eb1) into master (8799660) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   79.19%   79.03%   -0.16%     
==========================================
  Files          10       10              
  Lines        1951     1951              
==========================================
- Hits         1545     1542       -3     
- Misses        406      409       +3     

see 1 file with indirect coverage changes

@vtjnash vtjnash merged commit 41c0106 into master Nov 3, 2023
8 checks passed
@vtjnash vtjnash deleted the jn/julia51979 branch November 3, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants