catch_backtrace must be called early after catch #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state is erased somewhere in the nested try block.
(this might be a Julia bug)
Test case:
println(" ", 1, " ", Dates.Date(2016,1,1))
collect(Int64,[1.5])
on x86_64-apple-darwin15.4.0 from homebrew Version 0.4.5 (2016-03-18 00:58 UTC) this produces
1 2016-01-01
LoadError: InexactError()
while loading In[1], in expression starting on line 2
after this patch it produces an additional line:
in collect at array.jl:256
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state fetched by
catch_backtracemight get erased if IO operations occur in the same catch block beforecatch_backtraceis called.(this is a workaround to JuliaLang/julia#13947)
Test case (a less complex call to
printlndoesn't show the same problem):on x86_64-apple-darwin15.4.0 from homebrew Version 0.4.5 (2016-03-18 00:58 UTC) this produces
after this PR the output contains the backtrace as intended: