fix(vega): add v4 mime type #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v4 mime type is what is currently supported out of the box by Jupyter, v3 requires an extension to be installed
|
This is getting little ridiculous. Why don't they put the version number into the JSON content rather than continually updating the MIME type? |
stevengj
reviewed
Mar 9, 2019
|
@stevengj Ironically, they do both... It looks like VegaLite also just released v3. So it probably makes sense to do the comprehension for both mime types vegalite from 2:3 and vega from 3:5. I'll get that added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v4 mime type is what is currently supported out of the box by Jupyter, v3 requires an extension to be installed.
This PR adds the v4 mime type to the lists of supported mime types. MIME"application/vnd.vega.v3+json" was left for backwards compatibility. Vega recently released v5, so I expect this will need to be updated again in the near future.
I am concurrently putting in a PR for VegaLite.jl to update the mime type on that end too.