Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lineno to SourceFile #191

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Add lineno to SourceFile #191

merged 4 commits into from
Feb 14, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 11, 2023

Fixes original part of #190

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good 👍

I'd prefer a more specific name than lineno. Perhaps first_line?

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@c42f
Copy link
Member

c42f commented Feb 14, 2023

@timholy I added you to this repo so feel free to merge etc

@c42f
Copy link
Member

c42f commented Feb 14, 2023

I took the liberty of editing your description so that #191 doesn't get auto-closed

@timholy timholy merged commit 0747ea0 into JuliaLang:main Feb 14, 2023
@timholy timholy deleted the teh/add_lineno branch February 14, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants