Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow unbalanced bidirectional unicode #288

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

c42f
Copy link
Member

@c42f c42f commented May 18, 2023

Disallow unbalanced Unicode bidirectional formatting directives within strings and comments, to mitigate the "trojan source" vulnerability https://www.trojansource.codes

See also JuliaLang/julia#42918

Fix #242
Closes #270

Disallow unbalanced Unicode bidirectional formatting directives within
strings and comments, to mitigate the "trojan source" vulnerability
https://www.trojansource.codes

See also JuliaLang/julia#42918
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #288 (4b427da) into main (6e3782f) will increase coverage by 0.02%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   96.73%   96.75%   +0.02%     
==========================================
  Files          14       14              
  Lines        4038     4071      +33     
==========================================
+ Hits         3906     3939      +33     
  Misses        132      132              
Impacted Files Coverage Δ
src/kinds.jl 80.59% <ø> (ø)
src/parser.jl 98.26% <75.00%> (-0.06%) ⬇️
src/tokenize.jl 99.06% <98.21%> (+0.17%) ⬆️
src/parse_stream.jl 96.42% <100.00%> (+0.01%) ⬆️

@c42f c42f merged commit 4d2e561 into main May 18, 2023
@c42f c42f deleted the c42f/bidirectional-text-errors branch May 18, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant