Fix line numbers with source fragments #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 96.81% 96.78% -0.03%
==========================================
Files 14 14
Lines 4109 4111 +2
==========================================
+ Hits 3978 3979 +1
- Misses 131 132 +1
|
When parsing source code fragments incrementally with
* `Meta.parse(str, index)` or
* `parsestmt(str, index)`
we must avoid scanning the rest of `str` for line numbers for
efficiency. In this mode, the user is expected to provide `first_line`
to "manually" specify which line number we're counting from.
Admittedly this is a bit clunky and should be integrated better with
SourceFile (which should also be renamed - see issue #190) but for now
seems to be the most consistent way to approach things here.
c42f
force-pushed
the
c42f/fix-fragment-parsing-line-numbers
branch
from
fc8b04a to
28d2696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing source code fragments incrementally with
we must avoid scanning the rest of
strfor line numbers for efficiency. In this mode, the user is expected to providefirst_lineto "manually" specify which line number we're counting from.Admittedly this is a bit clunky and should be integrated better with SourceFile (which should also be renamed - see issue #190) but for now seems to be the most consistent way to approach things here.
Fixes a bug found over at JuliaLang/julia#46372 (comment)
Update: Switching to using
Vector{UInt8}for literal parsing also makes parsing toParseStreamandGreenNodearound 10% faster