Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #400

Merged
merged 6 commits into from
Mar 16, 2024
Merged

Update docs #400

merged 6 commits into from
Mar 16, 2024

Conversation

hyrodium
Copy link
Contributor

@hyrodium hyrodium commented Jan 3, 2024

  • Use Julia v1.10 in CI
  • Update docs/Manifest.toml (and use Documenter.jl v1)
  • Minor fixes in docs/make.jl

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6f2d15) 94.61% compared to head (9675b8b) 96.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   94.61%   96.54%   +1.92%     
==========================================
  Files          14       14              
  Lines        4178     4195      +17     
==========================================
+ Hits         3953     4050      +97     
+ Misses        225      145      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -15,7 +17,7 @@ makedocs(;
repo="https://github.com/JuliaLang/JuliaSyntax.jl/blob/{commit}{path}#L{line}",
sitename="JuliaSyntax.jl",
authors = "Claire Foster and contributors: https://github.com/JuliaLang/JuliaSyntax.jl/graphs/contributors",
strict = Documenter.except(:missing_docs)
warnonly = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to set warnonly=true? Or, should I put missing docs in the documentation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine :-)

@c42f
Copy link
Member

c42f commented Mar 16, 2024

Thank you ❤️

Sorry I've been absent as a reviewer lately ... real life is 😩

@c42f c42f merged commit bd29025 into JuliaLang:main Mar 16, 2024
22 of 31 checks passed
@hyrodium
Copy link
Contributor Author

Thanks for the merge! I hope you are doing well 😄

@c42f c42f mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants