Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tril(M, k) not documented #161

Closed
jiahao opened this issue Feb 1, 2015 · 6 comments
Closed

tril(M, k) not documented #161

jiahao opened this issue Feb 1, 2015 · 6 comments
Labels
docs This change adds or pertains to documentation

Comments

@jiahao
Copy link
Member

jiahao commented Feb 1, 2015

The two-argument forms of tril, tril!, triu, and triu! exist for some matrix types but are not documented. Furthermore, coverage over the special matrix types is spotty.

@jiahao jiahao added docs This change adds or pertains to documentation linear algebra labels Feb 1, 2015
@jakebolewski
Copy link
Member

tril and triu also do not do any bounds checking for out of range diagonals.

@kshyatt
Copy link
Contributor

kshyatt commented Apr 3, 2015

In particular, these special matrix types don't work with triu and tril (basically all the ones in Base.LinAlg):

  • Bidiagonal
  • Tridiagonal
  • SymTridiagonal
  • Hermitian
  • UpperTriangular
  • LowerTriangular
  • Diagonal

@ViralBShah
Copy link
Member

A lot of stuff doesn't work on special matrix types. I tend to use them sparingly, and only in linear algebra calls, and not much otherwise.

@jiahao
Copy link
Member Author

jiahao commented Apr 4, 2015

See #136

@kshyatt
Copy link
Contributor

kshyatt commented Aug 12, 2015

Finished by JuliaLang/julia#12574.

@kshyatt kshyatt closed this as completed Aug 12, 2015
@tkelman
Copy link

tkelman commented Aug 12, 2015

Still missing docs. nevermind, sorry, you must've done that a while back

@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

No branches or pull requests

5 participants