Added bounds checking to triu/tril. #11090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,9 @@ vecnorm2{T<:BlasFloat}(x::Union(Array{T},StridedVector{T})) = | |||
|
|
|||
| function triu!(M::AbstractMatrix, k::Integer) | |||
| m, n = size(M) | |||
| if((k > 0 && k > n) || (k < 0 && -k > m)) | |||
There was a problem hiding this comment.
I don't think the outer parentheses are not necessary.
There was a problem hiding this comment.
Indeed! Thanks for catching that. I'll fix and update the PR.
|
+1 |
tkelman
added a commit
that referenced
this pull request
May 2, 2015
Added bounds checking to triu/tril.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re JuliaLang/LinearAlgebra.jl#161, added bounds checking for
triu!andtril!. Added tests as well. There was one test intest/bitarray.jlthat was asking for out-of-bounds sub/superdiagonals which I modified as well.