Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix ci errors #1175

Closed
wants to merge 2 commits into from
Closed

ci: Fix ci errors #1175

wants to merge 2 commits into from

Conversation

inkydragon
Copy link
Member

@inkydragon inkydragon commented Jan 18, 2025

Trying to fix ci errors:

  • ❌ ci: resolve .ci/Manifest.toml with latest nightly version
    Version 1.12.0-DEV.1904 (2025-01-17) Commit 11c692e1084
  • Use julia v1.11
  • Fix all failed tests nothing to do

@inkydragon inkydragon changed the title ci: update .ci\Manifest.toml ci: Fix ci errors Jan 18, 2025
@inkydragon
Copy link
Member Author

We could successfully compile the system image, but many tests failed.
Is testing with stable version v1.11 a good option?

@inkydragon inkydragon marked this pull request as ready for review January 18, 2025 06:00
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (cecf025) to head (7ef85cf).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1175   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          34      34           
  Lines       15619   15619           
======================================
  Misses      15619   15619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inkydragon
Copy link
Member Author

After rebase, this pr passed all tests.

Maybe merge this first?
Or I'll add/switch to nightly again to see if it works now.

@inkydragon inkydragon marked this pull request as draft January 23, 2025 15:40
@KristofferC
Copy link
Member

KristofferC commented Jan 23, 2025

Imo we should run with nightly. Backport branches run with the respective julia version they target.

@inkydragon
Copy link
Member Author

Yes, so replaced by #1178

@inkydragon inkydragon closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants