Refine column ranges in _isbanded_impl
#1267
Merged
+37
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1267 +/- ##
==========================================
+ Coverage 92.00% 92.05% +0.05%
==========================================
Files 34 34
Lines 15487 15489 +2
==========================================
+ Hits 14249 14259 +10
+ Misses 1238 1230 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
force-pushed
the
jishnub/isbanded_colrange
branch
from
175e70e to
d3d3144
Compare
|
Gentle bump. To understand the change here, please look at the added example. This fixes the upper limit of the range of columns in the second case (where zeros are present both above and below the bands). |
jishnub
added a commit
that referenced
this pull request
May 12, 2025
Fixes the column ranges, so that these correctly correspond to the ranges over which there are top and bottom rows to consider beyond the bands. The change is to the upper limit of the range. (cherry picked from commit 95703b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the column ranges, so that these correctly correspond to the ranges over which there are top and bottom rows to consider beyond the bands. The change is to the upper limit of the range.