Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Clean up the log #13367

Merged
merged 3 commits into from
Feb 20, 2018
Merged

Clean up the log #13367

merged 3 commits into from
Feb 20, 2018

Conversation

andreasnoack
Copy link
Member

@andreasnoack andreasnoack commented Feb 15, 2018

Merging JuliaLang/julia#25662 JuliaLang/julia#25472 broke the version testing here printed an error in the log which is confusing when the tests fail for some other reason or because of timeout.

The Pkg deprecation warning also added a lot of noise. Finally, I've disabled running the tests in parallel. It completely messes up the log and was the original reason why I missed an error. It will make each build slower but I guess it shouldn't have an effect on the overall throughput since we can just run more builds concurrently. Is that a correct interpretation of Travis?

@nalimilan
Copy link
Member

The PR you mention is about indexin. The findfirst changes are much older, and we should be able to use Compat.findfirst for that.

@andreasnoack
Copy link
Member Author

Thanks. I've updated the link. I'm not sure if using packages in the package testing script is feasible/practical.

@andreasnoack andreasnoack changed the title In Julia 0.7, findfirst returns nothing when no results are found Clean up the log Feb 15, 2018
@andreasnoack andreasnoack merged commit 019150c into metadata-v2 Feb 20, 2018
@andreasnoack andreasnoack deleted the anj/test07 branch February 20, 2018 07:53
@tkelman
Copy link
Contributor

tkelman commented Feb 20, 2018

It will make each build slower but I guess it shouldn't have an effect on the overall throughput since we can just run more builds concurrently. Is that a correct interpretation of Travis?

No it is not. Each Travis VM has multiple virtual cores, which is what this had been making use of. Now it's only using a single core and letting the others that are allocated sit idle. Travis counts concurrency based on separate jobs, not how many cores are used within a single job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants