Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Add StaticArrays v0.9 upper cap for Plots #19050

Merged

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Oct 23, 2018

See JuliaPlots/Plots.jl#1802.
I don't understand why this wasn't catched by the CIBot in #19043.
It seems it didn't run the Plots tests while StaticArrays is in its dependencies.

@mkborregaard
Copy link

Great. It's probably due to JuliaCI/PackageEvaluator.jl#164 that it didn't run.

@fredrikekre
Copy link
Member

Wouldn't it be better to release StaticArrays 0.9.1?

@blegat
Copy link
Contributor Author

blegat commented Oct 23, 2018

StaticArrays has deprecated its FixedSizeArrays submodule which breaks Plots until it is updated.
Currently, all users doing ] up will end up with Plots not working anymore so this PR at least prevent this until Plots is updated. Plots is a widely used package so this PR should prevent many breakages.

@andreasnoack andreasnoack merged commit 9163f6a into JuliaLang:metadata-v2 Oct 23, 2018
@fredrikekre
Copy link
Member

Right but it is only deprecated so it shouldnt break stuff. Should fix StaticArrays too at least.

@blegat
Copy link
Contributor Author

blegat commented Oct 23, 2018

Right but it is only deprecated so it shouldnt break stuff. Should fix StaticArrays too at least.

Yes but they renamed it FixedSizeArraysWillBeRemoved. Apparently they wanted to break code but leave the opportunity to still use the submodule. I agree that a deprecation warning might have made the transition smoother.

@mkborregaard
Copy link

Daniel pushed a fix for this in Plots JuliaPlots/Plots.jl#1803

@c42f
Copy link
Member

c42f commented Oct 23, 2018

Apparently they wanted to break code but leave the opportunity to still use the submodule

julia> using StaticArrays.FixedSizeArrays
WARNING: StaticArrays.FixedSizeArrays is deprecatedStaticArrays.FixedSizeArrays is deprecated. Use StaticArrays directly.
 in module StaticArrays

julia> Vec(1,2,3)
3-element Vec{3,Int64}:
 1
 2
 3

We do continue to provide a StaticArrays.FixedSizeArrays binding via @deprecate_binding.

So I don't understand what went wrong here, yet.

@c42f
Copy link
Member

c42f commented Oct 23, 2018

Proposed fix: JuliaArrays/StaticArrays.jl#527

@c42f
Copy link
Member

c42f commented Oct 23, 2018

The reason for renaming these modules at all was simply so that we can get a proper deprecation warning via @deprecate_binding which is not exactly designed for deprecating bindings which are going to be removed entirely, and requires a "new" name. So I gave the old modules a new (nonsense) name which is what has backfired here, and pointed the old name at the new one using @deprecate_binding.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants