-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAN ANYONE HELP ME ON THIS #39
Comments
Don't panic. If you read error carefully, you'll find that extraction from the archive has failed, i.e.
|
thanks for your help. I installed 7-zip, i do not know how to verify the 7z command. my system is win10, the problem persist......... ima 100% new to julia, so kind of dont know what to do.... |
well I installed 7-zip, deleted other zip programs. 7-zip can run in cmd. but.... the problem persist...... |
Try to run |
Most likely the download is corrupt. Delete |
yep i deleted the file and re build it. it works. sorry for the double post for this and another issue. ill post only 1 place next timo:) |
Strange that there's even a checksum provided for that file here, which I would think should have automatically caught the issue. @staticfloat you're probably the person most familiar with how the BinDeps checksumming works (or is supposed to), any ideas? |
Oh yikes, the keyword argument is supposed to be |
oh good catch - yeah I think accepting both capitalizations in BinDeps would be the least error prone thing to do |
I don't like the idea of supporting two different case variants. The problem is more general anyway: any typo in the name of an argument will give silent failures. It would be much better to print a warning when an unknown argument is encountered. After a deprecation period, they could be turned into errors. |
That wouldn't be a bad idea either, but someone has to collect a list of every single accepted option argument in bindeps, write a validator function and decide where to run it, then make sure the master list of possible keyword arguments is prominent enough that everyone remembers to update it. |
Sure, that's a bit more work, but if we introduce |
I agree, multiple names for one option is a bad idea. Need to fix MbedTLS build script, and not BinDeps, even though chose of the name was unfortunate. |
Lower case is more idiomatic for a Julia keyword argument. Exactly what is the harm of accepting either? If it's a mistake that multiple people are likely to make, and neither of you are about to write a keyword argument warning checker, I'm for being more permissive. |
I would not want to encourage different parameter naming especially when there is no checks on which name is accepted. Next person will decide that |
I agree that the lower case is more idiomatic. So we could aim at deprecating the upper case version instead. |
I think people are less likely to write |
Checking for correct option pretense must be done as well.
|
We don't want to force people to provide a |
For reference, see JuliaPackaging/BinDeps.jl#221 regarding keyword arguments validation. |
The text was updated successfully, but these errors were encountered: