-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinDeps keyword argument validation #221
base: master
Are you sure you want to change the base?
Conversation
Thanks for this! Though looks like you need to support |
Yep, missed a bunch because I was only looking for |
Bump. I forget, was this ready to go? |
We should run the tests again just in case. |
There, I just rebased onto |
Apparently HttpParser hasn't been fixed since we removed the 0.4 deprecations on nightly. HttpParser has some API changes not yet resolved that mean it currently can't be tagged until an upgrade path is put in place for existing installs... and windows binaries are rebuilt for the new version. Will need a more precise validation callback etc but this is an issue for a different repo... |
Tested on OSX.