Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinDeps keyword argument validation #221

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BinDeps keyword argument validation #221

wants to merge 3 commits into from

Conversation

staticfloat
Copy link
Member

Tested on OSX.

@nalimilan
Copy link
Member

Thanks for this! Though looks like you need to support os (or at least accept it with a deprecation warning).

@staticfloat
Copy link
Member Author

Yep, missed a bunch because I was only looking for get(opts, :arg) instead of haskey(opts, :arg).

@tkelman
Copy link
Contributor

tkelman commented Jun 21, 2016

Bump. I forget, was this ready to go?

@staticfloat
Copy link
Member Author

We should run the tests again just in case.

@tkelman tkelman closed this Jun 21, 2016
@tkelman tkelman reopened this Jun 21, 2016
@staticfloat
Copy link
Member Author

There, I just rebased onto master. Let's make sure everything is still green.

@tkelman
Copy link
Contributor

tkelman commented Jun 21, 2016

Apparently HttpParser hasn't been fixed since we removed the 0.4 deprecations on nightly. HttpParser has some API changes not yet resolved that mean it currently can't be tagged until an upgrade path is put in place for existing installs... and windows binaries are rebuilt for the new version. Will need a more precise validation callback etc but this is an issue for a different repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants