Support Julia 1.2 #204
Support Julia 1.2 #204
Conversation
.travis.yml
Outdated
| after_success: | ||
| - julia -e 'cd(using Pkg; Pkg.dir("MbedTLS")); Pkg.add("Coverage"); using Coverage; Codecov.submit(process_folder())' | ||
| - julia -e 'ENV["TRAVIS_JULIA_VERSION"] != "1.1" && ENV["TRAVIS_OS_NAME"] != "linux" && exit(); using Pkg; Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())' |
There was a problem hiding this comment.
I don't think you need this TRAVIS_JULIA_VERSION thing anymore; you're only using 1.2+ above.
Project.toml
Outdated
| Sockets = "6462fe0b-24de-5631-8697-dd941f90decc" | ||
|
|
||
| [compat] | ||
| julia = "1.2.0" |
There was a problem hiding this comment.
I think you only want julia = "1.2" here, not julia = "1.2.0".
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=========================================
Coverage ? 71.95%
=========================================
Files ? 12
Lines ? 542
Branches ? 0
=========================================
Hits ? 390
Misses ? 152
Partials ? 0Continue to review full report at Codecov.
|
|
Should we upper bound the supported julia version for previous MbedTLS versions in the registry? |
|
Yes, we'll need to do that, otherwise pre-1.2 julia versions will run into the same issue. |
Should fix JuliaLang/julia#32220
@staticfloat, does this look right to you?