Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility to unsafe_read/write additions to base julia in v0.5 #30

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 11, 2016

No description provided.

@malmaud
Copy link
Contributor

malmaud commented Feb 11, 2016

Thanks!

malmaud added a commit that referenced this pull request Feb 11, 2016
add compatibility to unsafe_read/write additions to base julia in v0.5
@malmaud malmaud merged commit e916d93 into JuliaLang:master Feb 11, 2016
n = 0
N = length(msg)
while n < N
if Base.VERSION < v"0.5-"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be more specific about the version number

@malmaud
Copy link
Contributor

malmaud commented Apr 19, 2016

@vtjnash care to step in here?

@vtjnash vtjnash deleted the jn/compat branch April 20, 2016 23:31
@tkelman
Copy link
Contributor

tkelman commented Apr 21, 2016

Jameson, please respond. Which base PR did this API correspond to?

@vtjnash
Copy link
Member Author

vtjnash commented Apr 22, 2016

JuliaLang/julia#14766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants