Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Always run tests with code coverage enabled (remove the coverage-disabled CI jobs) #1006

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

KristofferC
Copy link
Member

I don't fully understand what this comment means (cc @IanButterworth) but running all tests with and without coverage seems a bit bananas so I'll check what happens if only coverage is used.

@IanButterworth
Copy link
Member

IIRC this pre-dated JuliaLang/julia#52123 so can be removed now.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (72387f9) to head (df83b9b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files           3        3           
  Lines         829      829           
=======================================
  Hits          697      697           
  Misses        132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DilumAluthge DilumAluthge changed the title remove running all tests with and without coverage CI: Always run tests with code coverage enabled (remove the coverage-disabled CI jobs) Nov 21, 2024
@DilumAluthge
Copy link
Member

IIRC this pre-dated JuliaLang/julia#52123 so can be removed now.

And indeed, the codecov/project commit status shows that the coverage on this PR is the same as the coverage on master.

So we'll be good to go here once the last CI job passes.

@DilumAluthge
Copy link
Member

CI is all green here.

Codecov statuses are also both green here.

@DilumAluthge DilumAluthge merged commit 8d6fce0 into master Nov 21, 2024
29 checks passed
@DilumAluthge DilumAluthge deleted the kc/coverage branch November 21, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants