Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg fails to print all output from subprocesses #3488

Closed
Tracked by #49433
vtjnash opened this issue May 22, 2023 · 3 comments
Closed
Tracked by #49433

Pkg fails to print all output from subprocesses #3488

vtjnash opened this issue May 22, 2023 · 3 comments
Labels
precompile Pkg.precompile

Comments

@vtjnash
Copy link
Member

vtjnash commented May 22, 2023

It seems there is some mistake in Pkg IO handling that results in it truncating the output from subprocesses. A possible reason is the mistaken use of IOBuffer, when that is supposed to be forbidden to use for stdout. One example is at

out = IOBuffer()

I have been too busy and forgot to implement the error when I added automatic conversion functionality (for stdin and BufferStream), but this may lead to problems with corrupt output. I think the upstream issue for this is
JuliaLang/julia#46768 (comment)

@IanButterworth IanButterworth added the precompile Pkg.precompile label May 22, 2023
@IanButterworth
Copy link
Member

IanButterworth commented May 22, 2023

when that is supposed to be forbidden to use for stdout

AFAICT the documentation of this is that it's explicitly not in the list in the note here https://docs.julialang.org/en/v1.10-dev/base/io-network/#Base.redirect_stdout

Would it be possible to improve the docs. Perhaps a short section on buffering best practices linked to in all relevant buffer types and redirect functions?

@vtjnash
Copy link
Member Author

vtjnash commented Aug 9, 2023

A second mistake is that someone called closed(iob), which prematurely truncates the stream and creates many problems.

@IanButterworth
Copy link
Member

Fixed by #3573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precompile Pkg.precompile
Projects
None yet
Development

No branches or pull requests

2 participants