Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parallel precompile out of Pkg #49433

Closed
7 of 8 tasks
KristofferC opened this issue Apr 19, 2023 · 3 comments
Closed
7 of 8 tasks

Move parallel precompile out of Pkg #49433

KristofferC opened this issue Apr 19, 2023 · 3 comments
Labels
compiler:precompilation Precompilation of modules

Comments

@KristofferC
Copy link
Member

KristofferC commented Apr 19, 2023

Parallel precompile is pretty much independent of Pkg. As Pkg is getting moved out of the sysimage it becomes awkward to have it there. For example, you still want parallel precompile for package load even if you haven't loaded Pkg in the session. And issues like JuliaLang/Pkg.jl#3442 also shows it is awkward to have to load Pkg in various environment just to get access to the precompilation feature.

Tasks

  1. precompile
    IanButterworth
  2. precompile
  3. precompile
    IanButterworth
  4. precompile
  5. bug precompile
  6. precompile windows
  7. precompile
    IanButterworth
  8. bug precompile
@vchuravy vchuravy changed the title Move parallel precompile into Pkg Move parallel precompile out of Pkg Apr 19, 2023
@brenhinkeller brenhinkeller added the compiler:precompilation Precompilation of modules label Aug 4, 2023
@IanButterworth
Copy link
Member

IanButterworth commented Aug 11, 2023

Once the code is moved over to Base it's going to be pretty difficult to maintain a version in Pkg on 1.10 which looks likely to become an LTS and in Base on 1.11+, so I've added all the filed issues that I think should be ideally dealt with before moving it over.

The list doesn't have to be completely done, it just makes it easier to do the more are.

@IanButterworth
Copy link
Member

One thing to bear in mind with this is that Pkg.precompile does extra Pkg things before precompiling if necessary, like resolve and instantiate. Once the parallel precompilation mechanic is in Base, if we wanted to avoid using Pkg in the code load precompilation path, there would need to be graceful errors if the environment isn't resolved or instantiated, telling the user to use Pkg to do that. That might be a bit of a UX regression.

@KristofferC
Copy link
Member Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:precompilation Precompilation of modules
Projects
None yet
Development

No branches or pull requests

3 participants