Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw for missing Versions.toml in the registry #1016

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Don't throw for missing Versions.toml in the registry #1016

merged 1 commit into from
Jan 25, 2019

Conversation

fredrikekre
Copy link
Member

Don't throw for missing Versions.toml in the registry, instead consider that the same as no versions, i.e. an empty existing file.

@fredrikekre
Don't throw for missing Versions.toml in the registry,
5e05aaf 
instead consider that the same as no versions, i.e.
an empty existing file.
@fredrikekre
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 25, 2019
@bors @fredrikekre
Merge #1016
1a6dd9a 
1016: Don't throw for missing Versions.toml in the registry r=fredrikekre a=fredrikekre

Don't throw for missing Versions.toml in the registry, instead consider that the same as no versions, i.e. an empty existing file.

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@KristofferC
Copy link
Member

Oh, so that is what fakeit means :D

@fredrikekre
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 25, 2019
@bors @fredrikekre
Merge #1016
c77adfd 
1016: Don't throw for missing Versions.toml in the registry r=fredrikekre a=fredrikekre

Don't throw for missing Versions.toml in the registry, instead consider that the same as no versions, i.e. an empty existing file.

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 25, 2019

Build succeeded

@bors bors bot merged commit 5e05aaf into master Jan 25, 2019
@bors bors bot deleted the fe/versions branch January 25, 2019 23:50
fredrikekre added a commit that referenced this pull request Feb 11, 2019
@fredrikekre
Don't throw for missing Versions.toml in the registry,
19d1602 
instead consider that the same as no versions, i.e.
an empty existing file.

(cherry picked from commit 5e05aaf, PR #1016)
fredrikekre added a commit that referenced this pull request Feb 11, 2019
@fredrikekre
Don't throw for missing Versions.toml in the registry,
97de6b5 
instead consider that the same as no versions, i.e.
an empty existing file.

(cherry picked from commit 5e05aaf, PR #1016)
fredrikekre added a commit that referenced this pull request Feb 11, 2019
@fredrikekre
Don't throw for missing Versions.toml in the registry,
4a22dfb 
instead consider that the same as no versions, i.e.
an empty existing file.

(cherry picked from commit 5e05aaf, PR #1016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @KristofferC @StefanKarpinski