Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt-in auto precompilation after Pkg.add, instantiate, update #2033

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

IanButterworth
Copy link
Member

Runs Pkg.precompile() after Pkg.add(), instantiate(), update()

Enabled by setting ENV["JULIA_PKG_PRECOMPILE_AUTO"]=1 etc.

@staticfloat
Copy link
Member

It's going to be a string; you want something like if parse(Int, get(ENV, "JULIA_PKG_PRECOMPILE_AUTO", "0")) == 1

@IanButterworth
Copy link
Member Author

IanButterworth commented Sep 23, 2020

What would be best? I didn't mean to pick a strategy.

Edit: I reviewed https://docs.julialang.org/en/v1/manual/environment-variables/ and that approach seems typical

@tkf
Copy link
Member

tkf commented Sep 23, 2020

Setting environment variables is not the cleanest way to configure the behavior of a package JuliaLang/julia#34726. Why not use (run-time) Preferences.jl?

@KristofferC
Copy link
Member

This is just a way for people to be able to try it out to collect feedback. It is not a permanent setting.

@staticfloat staticfloat merged commit 8f7afc9 into JuliaLang:master Sep 23, 2020
@IanButterworth IanButterworth deleted the ib/auto_precompile branch September 23, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants