PlatformEngines: stop disabling logging during symlink test #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I think #1807 by maybe storing something into the precompiled state that wasn't allowed. But just a guess. |
|
This PR fixes it in any case 😁 |
|
Looks like Pkg's dependency on Logging can be deleted after this. |
Closes #2061. Should be followed up by changing `symlink` not to warn but only throw an error (whose error message can include a warning to hint that symlinks don't work on Windows).
StefanKarpinski
force-pushed
the
sk/dont-disable-logging
branch
from
586e034 to
6085bb6
Compare
fredrikekre
reviewed
Oct 1, 2020
StefanKarpinski
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2061. Should be followed up by changing
symlinknot towarn but only throw an error (whose error message can include a
warning to hint that symlinks don't work on Windows).