-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports for 1.6, take 2. #2628
Conversation
36fdfa1
to
7228f38
Compare
I tested this locally against JuliaLang/julia#40702 and got the same error
No clue.. |
@KristofferC I've looked at this a few times and still don't have any idea what broke the undo tests |
2018f15 is the first bad commit for the undo tests, testing with JuliaLang/julia#40702 Also, 27ab070 seems like a bad backport as |
I think the problem is that the manifest equality is failing here https://github.com/JuliaLang/Pkg.jl/blob/kc/1.6/src/API.jl#L1539 I guess during the undo tests the Perhaps Though, I don't yet understand why the undo tests aren't failing on master.. Edit: On second thought.. I'm really not certain I've got a handle on this properly. When Edit edit: Seems like my suggestion passes #2650 but still not clear why it didn't fail on master |
The fix agreed with @KristofferC was to change the undo functionality to just consider equality wrt. the manifest deps, rather than change the equality method for the manifest type to do that |
@KristofferC @fredrikekre Is this good to go? |
No description provided.