Pkg test suite: in the TestArguments test package, relax the assertion that Base.JLOptions().depwarn is 1
#2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
Base.JLOptions().depwarn is 1TestArguments test package, relax the assertion that Base.JLOptions().depwarn is 1
…ion that `Base.JLOptions().depwarn` is `1`
DilumAluthge
force-pushed
the
dpa/test-testarguments-depwarn
branch
from
960e53b to
7ebd7cf
Compare
|
I'm going to merge this now so I can go ahead and try it out on Buildkite, but @c42f and @staticfloat please do still take a look and make sure that this change is okay. |
|
Yeah, this seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2817