Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --manifest to warn if showing manifest status #2991

Closed
wants to merge 1 commit into from

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 15, 2022

Alt to #2990

Fix #2989

Closes #2990

cc. @fingolfin @DilumAluthge

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KristofferC
Copy link
Member

KristofferC commented Feb 15, 2022

This doesn't make sense to me. Why would you then not show all packages (even those in the manifest) when you do status? The point about splitting up showing direct and indirect dependencies is that the direct dependencies are those you can directly change by changing the project file (e.g its compat) and it is those whose API you code against with the indirect dependencies being more an implementation detail of your direct dependencies. If all your packages are at the latest version but you still have some indirect dependency at the non latest version, that will not directly affect you since you are consuming the latest API of what you are depending on.

@DilumAluthge
Copy link
Member

If I understand correctly, this isn't about ] status, right? It's about ] update.

I think that there are plenty of people that will assume that if they do ] update, it will update all packages in their environment (both direct dependencies and indirect dependencies). So, if a user does ] update, and then, after the update, one or more indirect dependencies are not at the latest version, then I absolutely think that we should print a warning to the user.

@KristofferC
Copy link
Member

KristofferC commented Feb 16, 2022

then I absolutely think that we should print a warning to the user.

I don't think so because there is nothing as a user that you can do. If you are a power user / developer that wants to go and update the compat of your dependencies then you can just do st --manifest after. Showing warnings should be done very sparingly, people getting warnings when there is nothing they can really do is not user-friendly in my opinion. It is similar to how deprecation warnings are not shown by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mysterious "Some packages have new versions but cannot be upgraded" message
3 participants