improve inferrability of prune_graph!
#3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some invalidations when loading HDF5.jl
giordano
reviewed
Sep 16, 2022
Comment on lines
+1442
to
+1445
| new_vdict = Vector{Dict{VersionNumber, Int}}(undef, length(new_pvers)) | ||
| for new_p0 in eachindex(new_vdict) | ||
| new_vdict[new_p0] = Dict(vn => v0 for (v0,vn) in enumerate(new_pvers[new_p0])) | ||
| end |
There was a problem hiding this comment.
Wouldn't
new_vdict = Dict{VersionNumber, Int}[Dict(vn => v0 for (v0,vn) in enumerate(new_pvers[new_p0])) for new_p0 = 1:new_np]also work?
KristofferC
reviewed
Sep 19, 2022
src/Resolve/graphtype.jl
Outdated
| new_vdict[new_p0] = Dict(vn => v0 for (v0,vn) in enumerate(new_pvers[new_p0])) | ||
| end | ||
| # The code above is essentially equivalent to | ||
| # new_vdict = [Dict(vn => v0 for (v0,vn) in enumerate(new_pvers[new_p0])) for new_p0 = 1:new_np] |
There was a problem hiding this comment.
I think this whole chunk can used be written as
# explicitly writing out the loop since the generator equivalent caused type inference failure
There was a problem hiding this comment.
I will be AFK in the next few days. Could you please make the changes you suggested? Otherwise, I will revisit this some time in October.
KristofferC
added
latency
backport 1.8
KristofferC
pushed a commit
that referenced
this pull request
Sep 21, 2022
* improve inferrability of `prune_graph!` This fixes some invalidations when loading HDF5.jl * update comment Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> (cherry picked from commit 0d5230b)
KristofferC
pushed a commit
that referenced
this pull request
Sep 21, 2022
* improve inferrability of `prune_graph!` This fixes some invalidations when loading HDF5.jl * update comment Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> (cherry picked from commit 0d5230b)
KristofferC
added a commit
that referenced
this pull request
Oct 5, 2022
* improve inferrability of `prune_graph!` This fixes some invalidations when loading HDF5.jl * update comment Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved type stability to fix some invalidations. This is based on the following code:
I suggest the labels
latencyandbackport-1.8. With a recent build of Pkg based on therelease-1.8branch and this commit, I get