also check build ids when checking for staleness of precompile files #3308
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I don't know whether it's exactly this issue, but I've seen the phenomenon you describe quite frequently, and never tracked it down. If this fixes it, it's a significant QOL improvement. |
|
Fantastic! This bug has been eating up a lot of time and patience for quite some time now! |
|
Since I can't repro my original issue (I was being stupid not to save my |
IanButterworth
approved these changes
Jan 13, 2023
IanButterworth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a case (which I can't repro now) where
pkg> precompileconsidered everything precompiled, but loading the package still had to recompile. When I debugged, I saw that the check at https://github.com/JuliaLang/julia/blob/fec8304a8c6e2157759b76d20339b426201a5f61/base/loading.jl#L2602-L2606 failed which caused Julia to recompile the package.However, in Pkg, we only call the 2-arg version of
stale_cachefilewhich disables this check https://github.com/JuliaLang/julia/blob/fec8304a8c6e2157759b76d20339b426201a5f61/base/loading.jl#L2554-L2556This PR copies the recursive checks for staleness in https://github.com/JuliaLang/julia/blob/79ceb8dbeab1b5a47c6bd664214616c19607ffab/base/loading.jl#L1309-L1336 but it adds some caching to prevent checking this for the same package multiple times. This still leads to some slowdown. On a pretty big environment I measure before this change a "no-op" precompile to take 469ms while with this change it takes 834 ms. However, with some more caching in Base (JuliaLang/julia#48247) it now takes 578 ms which is not so bad compared to before.