Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile: add pid to waiting message #3583

Closed

Conversation

IanButterworth
Copy link
Member

See JuliaLang/julia#50914

Seems like the pid might useful for profiling what's lingering

Screenshot 2023-08-14 at 2 59 59 PM

@timholy
Copy link
Member

timholy commented Aug 14, 2023

If we decide it's actually useful to know the PID, then this would indeed be useful. Thanks!

I don't have time to play with this more today, but presumably this is easy to test. PyPlot 2.11.1 would make an easy test case, see JuliaPy/PyPlot.jl#573.

@IanButterworth
Copy link
Member Author

Hmm, yeah. This doesn't look too helpful in this case, which was just a Timer(30) added to the module

(PNGFiles) pkg> precompile
Precompiling project...
  1 dependency successfully precompiled in 32 seconds. 28 already precompiled.
  1 dependency had output during precompilation:
┌ PNGFiles [f57f5aa1-a3ce-4bc8-8ab9-96f992907883]
│  [pid 52880] waiting for IO to finish:
│   TYPE[FD/PID]       @UV_HANDLE_T->DATA
│   timer              @0x6000027cd480->0x12bf29ea0
│  
│  ======================================================================================
│  Information request received. A stacktrace will print followed by a 1.0 second profile
│  ======================================================================================
│  
│  signal (29): Information request: 29
│  kevent at /usr/lib/system/libsystem_kernel.dylib (unknown line)
│  unknown function (ip: 0x0)
│  
│  ==============================================================
│  Profile collected. A report will print at the next yield point
│  ==============================================================
│  
│  ┌ Warning: There were no samples collected in one or more groups.
│  │ This may be due to idle threads, or you may need to run your
│  │ program longer (perhaps by running it multiple times),
│  │ or adjust the delay between samples with `Profile.init()`.
│  └ @ Profile ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Profile/src/Profile.jl:1201
│  Overhead ╎ [+additional indent] Count File:Line; Function
│  =========================================================
│  Thread 1 Task 0x0000000102e18010 Total snapshots: 780. Utilization: 0%
│  
│  
│  [pid 52880] waiting for IO to finish:
│   TYPE[FD/PID]       @UV_HANDLE_T->DATA
│   timer              @0x6000027cd480->0x12bf29ea0
└  

@IanButterworth
Copy link
Member Author

There doesn't seem to be benefit to doing this. Also the output will be shown live in common dev usage patterns now thanks to #3582

@IanButterworth IanButterworth deleted the ib/precompile_pid branch August 16, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precompile Pkg.precompile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants