-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add JULIA_PKG_GC_AUTO env var #3642
Conversation
This should get documented here too: https://docs.julialang.org/en/v1/manual/environment-variables/#Pkg.jl |
Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! it could be nice to dynamically check before doing auto GC's rather than setting it in __init__
so one can set the ENV variable later. But this already seems an improvement so IMO that shouldn't block merging.
I think the general pattern of
|
Yeah, that second point is also what I was mostly concerned about. |
This was approved almost a year ago, but not merged. What gives? |
@staticfloat Is this good to merge once CI passes? |
Also bump @pfitzseb |
Should it be |
Yeah like |
Or |
Renamed the env var and added |
and rename env var to JULIA_PKG_GC_AUTO
4d81d2c
to
62fe923
Compare
This PR adds a
JULIA_PKG_DISABLE_AUTO_GC
environment variable to allow users to disable automatic garbage collection without reaching into Pkg's internals and setting_auto_gc_enabled[] = false
manually.