-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use historical stdlib dependency information #3911
Conversation
34ac794
to
708d9f9
Compare
This makes use of the new functionality in HistoricalStdlibVersions [0] to properly pull out the dependency information in old stdlibs. This fixes JuliaPackaging/HistoricalStdlibVersions.jl#9. [0] JuliaPackaging/HistoricalStdlibVersions.jl#23
708d9f9
to
0585e34
Compare
0585e34
to
837662b
Compare
One point of contention here; the
|
837662b
to
708d9f9
Compare
708d9f9
to
ea4db14
Compare
@KristofferC If you are happy with this, I will make a breaking |
Workspaces make dependency management so much easier, but tests aren't passing until JuliaLang/Pkg.jl#3911 is merged.
Just to double-check: the
Skimming that list, it looks like I'm responsible for 4 out of 7 of the usages. I'd be fine with doing a breaking change and then patching my packages to do the requisite |
Just a quick note: a few additional usages pop up if you change the |
Yes, and perhaps the right thing to do here is to provide a |
LGTM but I would prefer leaving the |
ea4db14
to
68651f0
Compare
Converting to draft so we don't accidentally merge before we remove the "drop me" commits. |
68651f0
to
62f8d8e
Compare
Alright, I'm happy with this, the new HSG version has been published and as long as @KristofferC's happy with it, I think we're good to merge. |
@KristofferC merge? |
Go for it! |
(I went for it!) |
This fixes support for nightly with the new Pkg version: JuliaLang/Pkg.jl#3911.
This fixes support for nightly with the new Pkg version: JuliaLang/Pkg.jl#3911.
This fixes support for nightly with the new Pkg version: JuliaLang/Pkg.jl#3911.
This fixes support for nightly with the new Pkg version: JuliaLang/Pkg.jl#3911.
* Add compat with HistoricalStdlibVersions v2 This fixes support for nightly with the new Pkg version: JuliaLang/Pkg.jl#3911. * Bump version
This makes use of the new functionality in HistoricalStdlibVersions [0]
to properly pull out the dependency information in old stdlibs. This
fixes JuliaPackaging/HistoricalStdlibVersions.jl#9.
[0] JuliaPackaging/HistoricalStdlibVersions.jl#23