Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Backports 1.10 #3965

Merged
merged 5 commits into from
Jul 24, 2024
Merged

[release-1.10] Backports 1.10 #3965

merged 5 commits into from
Jul 24, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jul 23, 2024 •
edited
Loading

@IanButterworth
Copy link
Member Author

@KristofferC I couldn't figure out the backport for #3851 because there are other unrelated changes in fixup_ext!

@IanButterworth
Copy link
Member Author

Oh we need to backport #3720 first

vtjnash and others added 2 commits July 23, 2024 16:42
@vtjnash @IanButterworth
extensions: fixup entire manifest (#3720)
99f6754 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719

(cherry picked from commit 77620a9)
@KristofferC @IanButterworth
fix not hardcoding "Project.toml" when fixing up extensions in manife…
861384c 
…st (#3851)

* fix not hardcoding "Project.toml" when fixing up extensions in manifest file

* abspath to be extra safe

---------

Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit 8875120)
@IanButterworth IanButterworth mentioned this pull request Jul 24, 2024
Merged
@KristofferC KristofferC merged commit bf83c38 into release-1.10 Jul 24, 2024
13 checks passed
@KristofferC KristofferC deleted the backports-release-1.10 branch July 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @KristofferC @fonsp @vtjnash