Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same PrecompileTools.jl approach as REPL to precompile #4024

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

Without this: (exposing pkg_precompile which it usually isn't)

julia> @time Pkg.pkg_precompile()
  1.796371 seconds (2.23 M allocations: 125.344 MiB, 4.53% gc time, 66.34% compilation time: 9% of which was recompilation)

With

julia> @time Pkg.pkg_precompile()
  0.929547 seconds (555.18 k allocations: 35.390 MiB, 2.02% gc time, 29.93% compilation time: 32% of which was recompilation)

The code is quite small. Do we want to make a utility in Base or just copy it here?

@IanButterworth IanButterworth changed the title use same PrecompileTools.jl approach as REPL to precompile Use same PrecompileTools.jl approach as REPL to precompile Sep 18, 2024
@KristofferC
Copy link
Sponsor Member

Nice nice. For now I think we can just keep it here?

@IanButterworth IanButterworth merged commit 308f9d3 into JuliaLang:master Sep 18, 2024
7 checks passed
@IanButterworth IanButterworth deleted the ib/precompiletools branch September 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants