Make concurrent-process package source installation safe #4168
+52
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/pidlock_download_source
branch
from
4db38bc to
274d247
Compare
IanButterworth
force-pushed
the
ib/pidlock_download_source
branch
from
274d247 to
3db4eb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3495
But only if all concurrent julia process installations have this fix.. I'm not sure there's a way to protect against older versions..
mvfrom temp dir to final path by checkingtree_hashbefore and after and deleting the destination if bad.Also, I split out enabling the TODO for tree_hash vs. expected sha on Windows because that's less clear to me #4167