Normalize Gitlab urls

[morris25]

Allows gitlab urls to be normalized by a separate protocol.

[StefanKarpinski]

Thanks for this—definitely good to have. I'm a bit bothered by how different the GitHub and GitLab logic appears to be at this point given that they seem like they should do very similar things. Is there any chance they can be made to mirror each other better or maybe even share logic?

[StefanKarpinski]

This is much cleaner! Thank you for the lovely refactor.

[omus]

bors try

[bors]

try

Build succeeded

• continuous-integration/travis-ci/push
• continuous-integration/appveyor/branch

[fredrikekre]

Would be great to get rid of the deprecations.

[StefanKarpinski]

Ok, so I feel bad because I think I may have suggested the current API in this PR, but it seems like using keyword arguments might be better. In other words something like this signature:

setprotocol!(;
    protocol::Union{Nothing, AbstractString} = nothing,
    domain::Union{Nothing, AbstractString} = nothing,
    user::Union{Nothing, AbstractString} = (protocol == "ssh" ? "git" : nothing),
)

That doesn't quite feel orthogonal either though. Argh, this is a bit tricky...

Also, did we have setprotocol! in Julia 1.0?

[ararslan]

Also, did we have setprotocol! in Julia 1.0?

Yes

[morris25]

@StefanKarpinski Is there anything I should do?

[StefanKarpinski]

I think this looks good. Hopefully we'll use a centralized server with a consistent URL scheme instead in the future so that this becomes unnecessary. We'll discuss on the next Pkg triage call and make a decision on this.

[KristofferC]

bors r+

[StefanKarpinski]

Revisiting, this API seems ok with me.

[bors]

Build failed

• continuous-integration/travis-ci/push

[KristofferC]

bors r+

[bors]

Build succeeded

• continuous-integration/appveyor/branch
• continuous-integration/travis-ci/push

[StefanKarpinski]

Crap, this should have been squashed.

[KristofferC]

:( the negative with Bors