Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rm: project.extras also contains dependency names #985

Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix rm: project.extras also contains dependency names #985

merged 1 commit into from
Jan 14, 2019

Conversation

00vareladavid
Copy link
Contributor

fixes #876

Thanks @fredrikekre for getting it down to a minimal repro.

@00vareladavid 00vareladavid changed the title fix rm: project.extras also contain dependency names fix rm: project.extras also contains dependency names Jan 9, 2019
@00vareladavid
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 9, 2019
@bors
Try #985:
be7a446
@bors
Copy link
Contributor

bors bot commented Jan 9, 2019

try

Build succeeded

@KristofferC
Copy link
Member

Nice!

@fredrikekre
Copy link
Member

Add a test?

@00vareladavid
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jan 14, 2019
@bors @00vareladavid
Merge #985
9839b33 
985: fix rm: `project.extras` also contains dependency names r=00vareladavid a=00vareladavid

fixes #876 

Thanks @fredrikekre for getting it down to a minimal repro.

Co-authored-by: David Varela <00.varela.david@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 14, 2019

Build succeeded

@bors bors bot merged commit 27d452d into JuliaLang:master Jan 14, 2019
@fredrikekre
Copy link
Member

Thanks for the fix!

Remember not to @ people in commit messages, now I get notifications whenever this commit is involved. I just got an email from bitbucket for example (https://bitbucket.org/UnofficialJuliaMirror/julialang-pkg.jl-44cfe95a-1eb2-52ea-b672-e2afdf69b78f/commits/9839b334210ec5f72302c773d9f8a70fd2943f55).

bors includes the top post of the PR in the merge-commit message as well, so use the --- modifier to split off longer discussions, and e.g. the @fredrikekre up there.

Pkg.jl/bors.toml

Line 7 in 9839b33

cut_body_after = "---"

@00vareladavid
Copy link
Contributor Author

Sorry about that! 😅 I didn't know you would end up getting pinged.

@fredrikekre fredrikekre mentioned this pull request Feb 4, 2019
Closed
@oxinabox
Copy link
Contributor

oxinabox commented Feb 8, 2019

Can this get backported?
It is really annoying.
(@nickrobinson251 reproduced the error in 1.0.3.)

@fredrikekre
Copy link
Member

It has the label so yea it will.

@oxinabox
Copy link
Contributor

oxinabox commented Feb 8, 2019

I should have said: Can we have it to be backported ASAP, and a patch release tagged early,
it is really annoying

@fredrikekre
Copy link
Member

You can help debug JuliaLang/julia#30954

fredrikekre pushed a commit that referenced this pull request Feb 11, 2019
@00vareladavid @fredrikekre
fix rm: project.extras also contain dependency names
266fca8 
(cherry picked from commit 27d452d, PR #985)
fredrikekre pushed a commit that referenced this pull request Feb 11, 2019
@00vareladavid @fredrikekre
fix rm: project.extras also contain dependency names
af69f3c 
(cherry picked from commit 27d452d, PR #985)
fredrikekre pushed a commit that referenced this pull request Feb 11, 2019
@00vareladavid @fredrikekre
fix rm: project.extras also contain dependency names
b13b473 
(cherry picked from commit 27d452d, PR #985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pkg sometimes removes [targets]
4 participants
@00vareladavid @KristofferC @fredrikekre @oxinabox