When pushing to a GitHub repository, use HTTPS #64
Conversation
| @@ -21,7 +21,7 @@ const cd = Pkg.Dir.cd | |||
| Return package `pkg` directory location through search. Additional `paths` are appended. | |||
| """ | |||
| function dir(pkg::AbstractString) | |||
| pkgsrc = Base.find_in_path(pkg, Pkg.dir()) | |||
| pkgsrc = Base.find_in_path(String(pkg), Pkg.dir()) | |||
There was a problem hiding this comment.
is this needed? shouldn't find_in_path be smart enough to handle this?
There was a problem hiding this comment.
You're right, but I wouldn't have put it if there wasn't some deprecation warning that told me so. Though I was on an old version of PkgDev, so maybe this was already fixed and rebase put it back.
There was a problem hiding this comment.
Ok, I suspect what happened is that I didn't have ca9fdc8
Since we can use the token we already have for API. Also clean a couple deprecations.
Keno
force-pushed
the
pull-request/1a52cf8a
branch
from
1a52cf8
to
3086c42
Compare
|
I'm gonna go ahead and merge this. We should probably also tag a new version. |
|
Agreed. The tests from #58 might fail on PackageEvaluator, I'm not sure. |
|
I think that's a fine trade-off. If it does, we'll fix it. Since other packages don't depend on this, we don't risk cascading failures. |
|
Did fail on PackageEvaluator: http://pkg.julialang.org/detail/PkgDev.html |
Since we can use the token we already have for API.
Also clean a couple deprecations.