-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register StyledStrings.jl 1.0 in general #5
Comments
To me, you would just register this 1.0 compatible version from a branch. No need to revert anything, or? I don't really see how this is a release blocker.
Maybe this is more suitable for the StyledStrings.jl repo? |
Ah yep, I suppose this could be a branch. In my mind, the timing here should line up with the 1.11 release, but I suppose that actually isn't a hard requirement. Happy to close + create a new issue there, or for you to just transfer this issue (I can't). |
Support for 1.0 is now a work in progress over at https://github.com/julialang/StyledStrings.jl/tree/julia1-compat |
Hope to register this package ASAP @tecosaur |
The current plan is to register this around the Julia 1.11 release, so that 1.0 can be as "up to date" as possible, since past that release my plan is to only push bugfixes to pre-1.11. |
@tecosaur Julia v1.11.0 is already in the beta testing phase, but the (weak) dependent packages are in trouble with testing. In general terms, there is no need to register v0.x. Also, since this is a community project, I don't think any particular individual should be held responsible for that. I understand that I am being rude. However, I don't think you are getting my intent. JuliaGraphics/ColorTypes.jl#302 (comment) |
I see it as rather important that the compat-registered version of StyledStrings mirrors the version in 1.11 as closely as possible. Rather crucially, the compat version also needs to vendor the new AnnotatedString functionality from Base. Currently there are three changes that I'm trying to get reviewed and merged for 1.11:
I do sympathise with this, I'm just not sure if quickly releasing something so that package management is happy is the right approach? Perhaps I'm just slightly caught by the sunk cost fallacy, but it feels to me that the code that will be in 1.11 is so very close to ironed down that it might be best to wait the just a little longer 🤞 to be able to register the "fully mirrors the functionality in 1.11" version. |
It is up to the package to determine if the incomplete In any case, you are the one who knows best about this library. So, v0.x registration probably should not take place. |
This process has been dragging on a bit. I'll tell you what, I'll see if I can't get the items I listed sorted within a week or so, and then make the aforementioned 1.0 release. If not I'm willing to re-evaluate the idea of a pre-release just so weakdeps are resolvable. |
Update: we're reaching the end of the week and ... it's all been merged! Now I just need to backport/grab the changes, make sure all the tests still pass on older version, and then we'll have the compat release I've been talking along for so long 😀 |
The compat version is about to be registered 🙂 |
As of JuliaLang/julia#49586 we have the StyledStrings stdlib. Thanks to it being an external stlib, we can also register it in General.
I think we can be a bit sneakier though, and do the following:
1.0
in general1.11
in generalI think we want to do this just before 1.11, so the registered 1.0 version behaves as near-identically as possible. This issue is mainly to serve as a tracked reminder for me to do so.
The text was updated successfully, but these errors were encountered: