Type piracy in package

[KristofferC]

All of this stuff:

StyledStrings.jl/src/io.jl

Lines 252 to 297 in 6901610

	write(io::IO, s::Union{<:AnnotatedString, SubString{<:AnnotatedString}}) =
	_ansi_writer(io, s, write)::Int
	print(io::IO, s::Union{<:AnnotatedString, SubString{<:AnnotatedString}}) =
	(write(io, s); nothing)
	escape_string(io::IO, s::Union{<:AnnotatedString, SubString{<:AnnotatedString}},
	esc = ""; keep = ()) =
	(_ansi_writer(io, s, (io, s) -> escape_string(io, s, esc; keep)); nothing)
	function write(io::IO, c::AnnotatedChar)
	if get(io, :color, false) == true
	termstyle(io, getface(c), getface())
	bytes = write(io, c.char)
	termstyle(io, getface(), getface(c))
	bytes
	else
	write(io, c.char)
	end
	end
	print(io::IO, c::AnnotatedChar) = (write(io, c); nothing)
	function show(io::IO, c::AnnotatedChar)
	if get(io, :color, false) == true
	out = IOBuffer()
	show(out, c.char)
	print(io, ''', AnnotatedString(String(take!(out)[2:end-1]), map(a -> (1:ncodeunits(c), a), c.annotations)), ''')
	else
	show(io, c.char)
	end
	end
	function write(io::IO, aio::Base.AnnotatedIOBuffer)
	if get(io, :color, false) == true
	# This does introduce an overhead that technically
	# could be avoided, but I'm not sure that it's currently
	# worth the effort to implement an efficient version of
	# writing from a AnnotatedIOBuffer with style.
	# In the meantime, by converting to an `AnnotatedString` we can just
	# reuse all the work done to make that work.
	write(io, read(aio, AnnotatedString))
	else
	write(io, aio.io)
	end
	end

looks to be a pretty bad type piracy and should probably be moved to Base.

[kimikage]

Somewhat related to #57, regarding the justification for this library to do the piracy.

[tecosaur]

Loosely at best, since here we're talking about moving some functionality from this library to Base, and #57 is more about what/how functionality should be backported to the compat version.

[kimikage]

That's right. However, isn't the "result" of that the same?
That is, when they are transferred to Base, julia1-compat pirates them anew.

[tecosaur]

I can't say I follow. In Julia >1.11 the julia1-compat version shouldn't be used.

[kimikage]

I am just referring to julia1-compat, i.e., in Julia <1.11.

The above piracy could be eliminated from StyledString as stdlib. As a result, the piracy left in julia1-compat will go from "mere backporting" to "pure piracy".

In other words, I am talking about the justification for piracy here, not how the code behaves.