Adjust to changed annotations function return form #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency, calling `annotations` on an AnnotatedString, whether an index or range is specified, now always returns a vector of region-annotation tuples. Previously, when an index was specified, only the annotations would be returned. Thus, code that relies on this previous behaviour must now apply `last` to each element of the returned vector.
vtjnash
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Feb 12, 2024
This is a generally nice simplification, that tweaks the `annotations` API. It also requires the adjustment in JuliaLang/StyledStrings.jl#38 to be made, hence the bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, calling
annotationson an AnnotatedString, whether anindex or range is specified, now always returns a vector of
region-annotation tuples.
Previously, when an index was specified, only the annotations would be
returned. Thus, code that relies on this previous behaviour must now
apply
lastto each element of the returned vector.