Call load_customisations! automatically, lazily #94
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been wary about doing lazy application of load_customisations!, but with the @noinline addition the calls are really cheap: only 1.5ns according to Chairmarks on my machine. Thus, the cost of calling it after initialisation will be negligeable for any non-trivial function. Having rolled this around further, other than printing I think only withfaces calls actually require loading of user styles to be valid. With these two realisations, calling load_customisations! lazily as appropriate seems like a bit of a no-brainer. We'll probably want to add this to public API eventually for non-text/html output implementations, but we can wait to see how this is bourne out first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #79, see the commit message for more details.