Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix deadlock caused by REPL blinking
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40
- Loading branch information
038d866
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the daily benchmark build, I will reply here when finished:
@nanosoldier
runbenchmarks(ALL, isdaily = true)
038d866
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan