Make Colon immutable. Fixes 18034.

(cherry picked from commit 06b171d) ref #18036
JuliaLang · Aug 20, 2016 · 20673d9 · 20673d9
1 parent 1d566a9
commit 20673d9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/base/essentials.jl b/base/essentials.jl
@@ -202,7 +202,7 @@ function isassigned(v::SimpleVector, i::Int)
 end
 
 # index colon
-type Colon
+immutable Colon
 end
 const (:) = Colon()
 

diff --git a/test/subarray.jl b/test/subarray.jl
@@ -484,3 +484,15 @@ u = (1,2:3)
 let size=(x,y)-> error("should not happen")
  @test X[1:end,2,2] == @view X[1:end,2,2]
 end
+
+# issue #18034
+# ensure that it is possible to create an isbits, LinearFast view of an immutable Array
+let
+ immutable ImmutableTestArray{T, N} <: Base.DenseArray{T, N}
+ end
+ Base.size(::Union{ImmutableTestArray, Type{ImmutableTestArray}}) = (0, 0)
+ Base.linearindexing(::Union{ImmutableTestArray, Type{ImmutableTestArray}}) = Base.LinearFast()
+ a = ImmutableTestArray{Float64, 2}()
+ @test Base.linearindexing(view(a, :, :)) == Base.LinearFast()
+ @test isbits(view(a, :, :))
+end