Skip to content

Commit

Permalink
Merge pull request #25746 from JuliaLang/aa/build-warns
Browse files Browse the repository at this point in the history
Avoid Julia warnings during the build
  • Loading branch information
StefanKarpinski authored Jan 26, 2018
2 parents ebc5b2c + 2cc1491 commit 296d572
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 35 deletions.
8 changes: 4 additions & 4 deletions base/reducedim.jl
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ reducedim(op, A::AbstractArray, region) = mapreducedim(identity, op, A, region)

##### Specific reduction functions #####
"""
sum(A, dims)
sum(A::AbstractArray, dims)
Sum elements of an array over the given dimensions.
Expand All @@ -330,7 +330,7 @@ julia> sum(A, 2)
7
```
"""
sum(A, dims)
sum(A::AbstractArray, dims)

"""
sum!(r, A)
Expand All @@ -357,7 +357,7 @@ julia> sum!([1 1], A)
sum!(r, A)

"""
prod(A, dims)
prod(A::AbstractArray, dims)
Multiply elements of an array over the given dimensions.
Expand All @@ -378,7 +378,7 @@ julia> prod(A, 2)
12
```
"""
prod(A, dims)
prod(A::AbstractArray, dims)

"""
prod!(r, A)
Expand Down
1 change: 1 addition & 0 deletions base/uuid.jl
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ let groupings = [1:8; 10:13; 15:18; 20:23; 25:36]
end

let groupings = [36:-1:25; 23:-1:20; 18:-1:15; 13:-1:10; 8:-1:1]
global string
function string(u::UUID)
u = u.value
a = Base.StringVector(36)
Expand Down
60 changes: 29 additions & 31 deletions stdlib/Dates/src/parse.jl
Original file line number Diff line number Diff line change
Expand Up @@ -46,41 +46,39 @@ Return a 3-element tuple `(values, pos, num_parsed)`:

# Pre-assign variables to defaults. Allows us to use `@goto done` without worrying about
# unassigned variables.
assign_defaults = Expr[
quote
assign_defaults = Expr[]
for (name, default) in zip(value_names, value_defaults)
push!(assign_defaults, quote
$name = $default
end
for (name, default) in zip(value_names, value_defaults)
]
end)
end

vi = 1
parsers = Expr[
begin
if directives[i] <: DatePart
name = value_names[vi]
val = Symbol(:val, name)
vi += 1
quote
pos > len && @goto done
$val, next_pos = tryparsenext(directives[$i], str, pos, len, locale)
$val === nothing && @goto error
$name = $val
pos = next_pos
num_parsed += 1
directive_index += 1
end
else
quote
pos > len && @goto done
delim, next_pos = tryparsenext(directives[$i], str, pos, len, locale)
delim === nothing && @goto error
pos = next_pos
directive_index += 1
end
end
parsers = Expr[]
for i = 1:length(directives)
if directives[i] <: DatePart
name = value_names[vi]
val = Symbol(:val, name)
vi += 1
push!(parsers, quote
pos > len && @goto done
$val, next_pos = tryparsenext(directives[$i], str, pos, len, locale)
$val === nothing && @goto error
$name = $val
pos = next_pos
num_parsed += 1
directive_index += 1
end)
else
push!(parsers, quote
pos > len && @goto done
delim, next_pos = tryparsenext(directives[$i], str, pos, len, locale)
delim === nothing && @goto error
pos = next_pos
directive_index += 1
end)
end
for i in 1:length(directives)
]
end

quote
directives = df.tokens
Expand Down

2 comments on commit 296d572

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.