return a Vector from keys(::RegexMatch)

correct test of RegexMatch keys
JuliaLang · Nov 13, 2020 · 3a5a603 · 3a5a603
1 parent 4a98e23
commit 3a5a603
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/base/regex.jl b/base/regex.jl
@@ -154,7 +154,7 @@ end
 
 function keys(m::RegexMatch)
     idx_to_capture_name = PCRE.capture_names(m.regex.regex)
-    return ntuple(length(m.captures)) do i
+    return map(eachindex(m.captures)) do i
         # If the capture group is named, return it's name, else return it's index
         get(idx_to_capture_name, i, i)
     end

diff --git a/test/regex.jl b/test/regex.jl
@@ -88,7 +88,7 @@
         @test !haskey(m, "foo")
         @test (m[:a], m[2], m["b"]) == ("x", "y", "z")
         @test sprint(show, m) == "RegexMatch(\"xyz\", a=\"x\", 2=\"y\", b=\"z\")"
-        @test keys(m) = (:a, 2, :b)
+        @test keys(m) == [:a, 2, :b]
     end
 
     # Backcapture reference in substitution string