Skip to content

Commit

Permalink
compiler: fix performance issue introduced in #48962 (#49036)
Browse files Browse the repository at this point in the history 
`bb_rename_pred` was captured by #48962, so this commit fixes it up.
This was successfully detected by:
`JET.report_opt(CC.batch_inline!, (CC.IRCode,Vector{Pair{Int,Any}},Bool,CC.OptimizationParams))`
  • Loading branch information
@aviatesk
aviatesk authored Mar 17, 2023
1 parent 5e4669c commit 403e4e2
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion base/compiler/ssair/ir.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1349,7 +1349,9 @@ function process_node!(compact::IncrementalCompact, result_idx::Int, inst::Instr
elseif isa(stmt, PhiNode)
if cfg_transforms_enabled
# Rename phi node edges
map!(i -> bb_rename_pred[i], stmt.edges, stmt.edges)
let bb_rename_pred=bb_rename_pred
map!(i::Int32 -> bb_rename_pred[i], stmt.edges, stmt.edges)
end

# Remove edges and values associated with dead blocks. Entries in
# `values` can be undefined when the phi node refers to something
Expand Down

2 comments on commit 403e4e2

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

Please sign in to comment.