-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
triple quoted strings: don't dedent interpolates
Before: julia> s = """ $("\n ") """ "\n\n" After: julia> s = """ $("\n ") """ "\n \n" Plus some minor cleanup of 333bb87.
- Loading branch information
Showing
2 changed files
with
31 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no PR. I don't recall you asking about this, but sure, that's possible.
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go read #11815
"""
a
$var
b"""
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9cd6ad4:
333bb87:
4f4938e:
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you are trying to show there. 4f4938e fixed one of the things I was trying to bring up in #11815. I thought a problem still remained with totally blank lines, but I can't reproduce now.
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nolta is showing that the example that you provided in that comment works identically in all three commits, so it seems irrelevant to this change.
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lost the indenting in cut and paste, sorry, now I see the confusion. Also depends on what var is set to, if var is a set to a blank line, or something with indentation.
4f4938e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand what you're trying to say, Scott. It doesn't matter what
var
is set too:(this is true on 9cd6ad4, 333bb87, and 4f4938e)
4f4938e fixes a very obscure corner case, only triggered when interpolating raw string literals.