Skip to content

Commit

Permalink
Fix atahn to atanh (#17977)
Browse files Browse the repository at this point in the history
* Fix atahn to atanh

* More tests
  • Loading branch information
kshyatt authored and tkelman committed Aug 12, 2016
1 parent 17e0d2b commit 5838a12
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion base/special/trig.jl
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ end

for (tfa, tfainv, hfa, hfainv, fn) in ((:asec, :acos, :asech, :acosh, "secant"),
(:acsc, :asin, :acsch, :asinh, "cosecant"),
(:acot, :atan, :acoth, :atahn, "cotangent"))
(:acot, :atan, :acoth, :atanh, "cotangent"))
tname = string(tfa)
hname = string(hfa)
@eval begin
Expand Down
10 changes: 10 additions & 0 deletions test/math.jl
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,16 @@ end
@test exp2(Float16(2.)) exp2(2.)
@test log(e) == 1

#test abstractarray trig fxns
TAA = rand(2,2)
TAA = (TAA + TAA.')/2.
STAA = Symmetric(TAA)
@test full(atanh(STAA)) == atanh(TAA)
@test full(asinh(STAA)) == asinh(TAA)
@test full(acosh(STAA+Symmetric(ones(TAA)))) == acosh(TAA+ones(TAA))
@test full(acsch(STAA+Symmetric(ones(TAA)))) == acsch(TAA+ones(TAA))
@test full(acoth(STAA+Symmetric(ones(TAA)))) == acoth(TAA+ones(TAA))

# check exp2(::Integer) matches exp2(::Float)
for ii in -2048:2048
expected = exp2(float(ii))
Expand Down

2 comments on commit 5838a12

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.