Deprecate eye(::Type{Diagonal{T}}, m::Integer) method.

NEWS.md

@@ -302,6 +302,9 @@ Library improvements
 
  * The `crc32c` function for CRC-32c checksums is now exported ([#22274]).
 
+ * `eye(::Type{Diagonal{T}}, m::Integer)` has been deprecated in favor of
+ `Diagonal{T}(I, m)` ([#24413]).
+
  * The output of `versioninfo` is now controlled with keyword arguments ([#21974]).
 
  * The function `LibGit2.set_remote_url` now always sets both the fetch and push URLs for a

base/deprecated.jl

@@ -1786,6 +1786,8 @@ end
  @deprecate get_creds!(cache::CachedCredentials, credid, default) get!(cache, credid, default)
 end
 
+@deprecate eye(::Type{Diagonal{T}}, n::Int) where {T} Diagonal{T}(I, n)
+
 export tic, toq, toc
 function tic()
  depwarn("tic() is deprecated, use @time, @elapsed, or calls to time_ns() instead.", :tic)

base/linalg/diagonal.jl

@@ -341,8 +341,6 @@ function logdet(D::Diagonal{<:Complex}) # make sure branch cut is correct
  z = sum(log, D.diag)
  complex(real(z), rem2pi(imag(z), RoundNearest))
 end
-# identity matrices via eye(Diagonal{type},n)
-eye(::Type{Diagonal{T}}, n::Int) where {T} = Diagonal(ones(T,n))
 
 # Matrix functions
 for f in (:exp, :log, :sqrt,

base/linalg/uniformscaling.jl

@@ -374,4 +374,4 @@ chol(J::UniformScaling, args...) = ((C, info) = _chol!(J, nothing); @assertposde
 
 ## Diagonal construction from UniformScaling
 Diagonal{T}(s::UniformScaling, m::Integer) where {T} = Diagonal{T}(fill(T(s.λ), m))
-Diagonal(s::UniformScaling, m::Integer) where {T} = Diagonal{eltype(s)}(s, m)
+Diagonal(s::UniformScaling, m::Integer) = Diagonal{eltype(s)}(s, m)

test/linalg/diagonal.jl

@@ -29,7 +29,6 @@ srand(1)
  end
 
  @testset "Basic properties" begin
- @test eye(Diagonal{elty},n) == Diagonal(ones(elty,n))
  @test_throws ArgumentError size(D,0)
  @test typeof(convert(Diagonal{Complex64},D)) <: Diagonal{Complex64}
  @test typeof(convert(AbstractMatrix{Complex64},D)) <: Diagonal{Complex64}