fix perf regression for bitrand (#26529)

JuliaLang · Mar 22, 2018 · 6647086 · 6647086
1 parent ef0ef80
commit 6647086
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/stdlib/Random/src/Random.jl b/stdlib/Random/src/Random.jl
@@ -198,19 +198,18 @@ rand(rng::AbstractRNG, ::UniformT{T}) where {T} = rand(rng, T)
 
 #### scalars
 
-rand(rng::AbstractRNG, X) = rand(rng, Sampler(rng, X, Val(1)))
-rand(rng::AbstractRNG=GLOBAL_RNG, ::Type{X}=Float64) where {X} =
-    rand(rng, Sampler(rng, X, Val(1)))
+rand(rng::AbstractRNG, X)                                      = rand(rng, Sampler(rng, X, Val(1)))
+rand(rng::AbstractRNG=GLOBAL_RNG, ::Type{X}=Float64) where {X} = rand(rng, Sampler(rng, X, Val(1)))
 
-rand(X) = rand(GLOBAL_RNG, X)
+rand(X)                   = rand(GLOBAL_RNG, X)
 rand(::Type{X}) where {X} = rand(GLOBAL_RNG, X)
 
 #### arrays
 
-rand!(A::AbstractArray{T}, X) where {T} = rand!(GLOBAL_RNG, A, X)
+rand!(A::AbstractArray{T}, X) where {T}             = rand!(GLOBAL_RNG, A, X)
 rand!(A::AbstractArray{T}, ::Type{X}=T) where {T,X} = rand!(GLOBAL_RNG, A, X)
 
-rand!(rng::AbstractRNG, A::AbstractArray{T}, X) where {T} = rand!(rng, A, Sampler(rng, X))
+rand!(rng::AbstractRNG, A::AbstractArray{T}, X) where {T}             = rand!(rng, A, Sampler(rng, X))
 rand!(rng::AbstractRNG, A::AbstractArray{T}, ::Type{X}=T) where {T,X} = rand!(rng, A, Sampler(rng, X))
 
 function rand!(rng::AbstractRNG, A::AbstractArray{T}, sp::Sampler) where T

diff --git a/stdlib/Random/src/misc.jl b/stdlib/Random/src/misc.jl
@@ -2,7 +2,7 @@
 
 ## rand!(::BitArray) && bitrand
 
-function rand!(rng::AbstractRNG, B::BitArray)
+function rand!(rng::AbstractRNG, B::BitArray, ::SamplerType{Bool})
     isempty(B) && return B
     Bc = B.chunks
     rand!(rng, Bc)